Skip to content

APC.PowerChutePersonalEdition version 3.1.0#19373

Closed
mddtest wants to merge 1 commit intomicrosoft:masterfrom
mddtest:autogenerated/APC.PowerChutePersonalEdition/ae049584-72c9-452d-8651-ae450e71a916
Closed

APC.PowerChutePersonalEdition version 3.1.0#19373
mddtest wants to merge 1 commit intomicrosoft:masterfrom
mddtest:autogenerated/APC.PowerChutePersonalEdition/ae049584-72c9-452d-8651-ae450e71a916

Conversation

@mddtest
Copy link
Copy Markdown
Contributor

@mddtest mddtest commented Jun 30, 2021 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented Jun 30, 2021

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 30, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jun 30, 2021
@ghost ghost assigned mddtest Jun 30, 2021
@ghost
Copy link
Copy Markdown

ghost commented Jun 30, 2021

Hello @mddtest,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 30, 2021
@mddtest
Copy link
Copy Markdown
Contributor Author

mddtest commented Jun 30, 2021

I will get that fixed tomorrow. The sandbox tool is broken so installed on main pc no issue

@ghost ghost added Needs: Attention and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 30, 2021
OfficialEsco
OfficialEsco suggested changes Jul 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@OfficialEsco OfficialEsco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 2, 2021
mddtest
mddtest commented Jul 8, 2021
View reviewed changes
manifests/a/APC/PowerChutePersonalEdition/3.1.0/APC.PowerChutePersonalEdition.installer.yaml
InstallerType: nullsoft
InstallerUrl: https://download.schneider-electric.com/files?p_File_Name=PCPE_3.1.0.exe
InstallerSha256: 06CDB01B2E23ED72452FF090212BA72B5A250C16C41485ECD05D4AC9F75E25FF
ManifestType: installer
Copy link
Copy Markdown
Contributor Author

@mddtest mddtest Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InstallerSwitches:
Silent: /silent
SilentWithProgress: /silent

Copy link
Copy Markdown
Contributor

@ItzLevvie ItzLevvie Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switches are already included in the manifest as part of InstallerType: nullsoft which runs the manifest with /S from https://github.com/microsoft/winget-cli/blob/cf6f8e58195bf033a1a5872f7b800866cd27a586/src/AppInstallerCommonCore/Manifest/ManifestCommon.cpp#L362-L368

/silent is not a valid switch for nullsoft applications.

@mddtest
Copy link
Copy Markdown
Contributor Author

mddtest commented Jul 8, 2021

image

This will come up because no APC unit is found. so not sure if we will be able to add this one as the bot wont have a APC.

@denelon
Copy link
Copy Markdown
Collaborator

denelon commented Jul 12, 2021

@mddtest thanks for letting us know about the hardware requirement. Now we need a giant UPS to go with that awesome gaming rig we need to validate some of the NVidia software 😁

@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. Hardware Specific hardware is required - See #199504 and removed Needs: Attention labels Jul 12, 2021
@mddtest
Copy link
Copy Markdown
Contributor Author

mddtest commented Jul 12, 2021

I can volunteer if given the funds still rocking a 2600k.,🤣

@denelon denelon mentioned this pull request Aug 30, 2021
Closed
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 13, 2022
@stephengillie
Copy link
Copy Markdown
Collaborator

stephengillie commented Dec 15, 2023

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 15, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Blocking-Issue Manifest validation is blocked by a known issue. label Dec 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 15, 2023
@stephengillie
Copy link
Copy Markdown
Collaborator

stephengillie commented Dec 15, 2023

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 15, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Dec 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. Retry-1 flag to indicate retried labels Dec 15, 2023
@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented Dec 16, 2023

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 16, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 16, 2023
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 16, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Dec 16, 2023
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service bot commented Dec 21, 2023

Hello @mddtest,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@OfficialEsco OfficialEsco OfficialEsco requested changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mddtest mddtest

Labels

Hardware Specific hardware is required - See #199504 Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Retry-1 flag to indicate retried Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mddtest @wingetbot @denelon @stephengillie @ItzLevvie @OfficialEsco