Skip to content

New version: Sigil-Ebook.PageEdit version 2.1.0#147897

Merged
stephengillie merged 3 commits intomicrosoft:masterfrom
Trenly:Sigil-Ebook.PageEdit-2.1.0-7111490
Aug 27, 2024
Merged

New version: Sigil-Ebook.PageEdit version 2.1.0#147897
stephengillie merged 3 commits intomicrosoft:masterfrom
Trenly:Sigil-Ebook.PageEdit-2.1.0-7111490

Conversation

@Trenly
Copy link
Copy Markdown
Contributor

@Trenly Trenly commented Apr 5, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 5, 2024
@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

2024-04-05 07:35:26.318 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFC396BC11F: (caller: 00007FFC39448D6F) LogHr(1) tid(15d8) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFC395C2B08: (caller: 00007FFC3966BC20) Exception(1) tid(15d8) 8A15005E ]
2024-04-05 07:35:26.318 [REPO] Failed to open available source: msstore
2024-04-05 07:35:34.198 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFC21B0C11F: (caller: 00007FFC21898D6F) LogHr(1) tid(aec) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFC21A12B08: (caller: 00007FFC21ABBC20) Exception(1) tid(aec) 8A15005E ]
2024-04-05 07:35:34.198 [REPO] Failed to open available source: msstore
2024-04-05 07:35:35.683 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

(Automated response - build 876.)

@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented Apr 5, 2024

2024-04-05 07:35:35.683 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

@denelon - This definitely seems to be a CLI issue and not a manifest issue

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 5, 2024
@stephengillie
Copy link
Copy Markdown
Collaborator

This version of VCRedist appears to not have a user scope. Could this be a scope mismatch?

@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented Apr 5, 2024

This version of VCRedist appears to not have a user scope. Could this be a scope mismatch?

It's possible. Unless something changed in the CLI or pipelines recently though, I thought that the scope was omitted when searching for dependencies?

I can very easily foresee many, many cases where a dependency is only available in machine scope but the requested package is available in both user or machine scope.

I also know that many wix and burn packages have machine scope specified because the installers only ever write to HKLM even if it is a user scoped install.

If the dependency flow takes a hard requirement when --scope is passed in, then many manifests which were previously working may now be broken due to newer versions of the dependent package specifying scope differently than expected

@dougmassay
Copy link
Copy Markdown
Contributor

Scope should not matter in the installer verification pipeline with regard to dependencies in my opinion. The winget client can easily accommodate a machine scope dependency (in a user scope install) by prompting for admin elevation. This installer failure where dependencies are concerned is new behavior.

I had the very same issue with the recent 2.1.0 Sigil-Ebook.Sigil update: #147284

My only recourse to get it merged was to remove the dependency from the user scope installer altogether. I don't find that to be a very pleasing workaround.

@dougmassay
Copy link
Copy Markdown
Contributor

A further note: the VCRedist.2015+.x64 dependency package in my manifests has never had a user scope installer available. And it never mattered to my manifests in the past.

@stephengillie
Copy link
Copy Markdown
Collaborator

@wingetbot run

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. labels Apr 8, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 8, 2024
@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

2024-04-08 11:17:39.309 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFA5924C11F: (caller: 00007FFA58FD8D6F) LogHr(1) tid(1ea4) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFA59152B08: (caller: 00007FFA591FBC20) Exception(1) tid(1ea4) 8A15005E ]
2024-04-08 11:17:39.309 [REPO] Failed to open available source: msstore
2024-04-08 11:17:47.858 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFA3908C11F: (caller: 00007FFA38E18D6F) LogHr(1) tid(18a0) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFA38F92B08: (caller: 00007FFA3903BC20) Exception(1) tid(18a0) 8A15005E ]
2024-04-08 11:17:47.859 [REPO] Failed to open available source: msstore
2024-04-08 11:17:49.119 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

(Automated response - build 876.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Apr 14, 2024
@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented Apr 14, 2024

Still pending investigation on the cli side

@microsoft-github-policy-service microsoft-github-policy-service bot removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Apr 14, 2024
@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Installation-Error Error installing application labels May 7, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 7, 2024
@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

2024-05-07 12:27:05.169 [REPO] Failed to open available source: msstore
2024-05-07 12:27:13.367 [REPO] Failed to open available source: msstore
2024-05-07 12:27:14.703 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

(Automated response - build 880.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 13, 2024
@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented May 13, 2024

Bump

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels May 13, 2024
@stephengillie stephengillie added the Blocking-Issue Manifest validation is blocked by a known issue. label May 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 4, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 27, 2024
@stephengillie stephengillie enabled auto-merge (squash) August 27, 2024 16:29
@stephengillie stephengillie merged commit 1570220 into microsoft:master Aug 27, 2024
@wingetbot
Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Update Request]: PageEdit v2.1.0

5 participants