Microsoft.WindowsTerminal version 1.17.11461.0#108350
Microsoft.WindowsTerminal version 1.17.11461.0#108350DHowett wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hello @DHowett, The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request. Template: msftbot/validationError/installation/general |
|
The pull request failed due to Microsoft.UI.Xaml.2.7. |
|
Hello @DHowett, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
1 similar comment
|
Hello @DHowett, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
|
Hello @DHowett, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
1 similar comment
|
Hello @DHowett, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
|
@stephengillie Can you add blocking issue with dependcies? Otherwise, the pull request will closed automatically. |
|
Hello @DHowett, This package appears to require dependencies in order to install successfully. This PR is blocked until support for dependencies is implemented in: Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue. Template: msftbot/blockingIssue/dependencySupport |
|
@stephengillie @DHowett winget 1.6 supports dependencies could this pr be updated? |
|
That's great news! Somebody will need to explain how to do that 😄 |
|
IIRC, this depended on WinUI.Xaml version 2.8 correct? 👀 Edit: let's find out i guess |
|
@wingetbot run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
So, looks like it depends on -
Looks like we need to add VCLibs to the repository first. We already have WinUI Xaml 2.7 in the repo. |
|
Honestly, we might just want to skip this version. It is the last version that requires the The version that is available online is--regrettably--insanely out of date. They will not release an updated version. |
|
Automatic Validation ended with: |
Yep - I was going to suggest the dependency once #120905 gets merged |
Since you're the publisher - that's completely up to you 😄 |
| - silent | ||
| Commands: | ||
| - wt | ||
| PackageFamilyName: Microsoft.WindowsTerminal_8wekyb3d8bbwe |
There was a problem hiding this comment.
| PackageFamilyName: Microsoft.WindowsTerminal_8wekyb3d8bbwe | |
| PackageFamilyName: Microsoft.WindowsTerminal_8wekyb3d8bbwe | |
| Dependencies: | |
| PackageDependencies: | |
| - PackageIdentifier: Microsoft.UI.Xaml.2.7 |
There was a problem hiding this comment.
In a sandbox environment, this package also requires VCLibs. We would have to do something like
Dependencies:
PackageDependencies:
- PackageIdentifier: Microsoft.VCLibs.Desktop.14
MinimumVersion: 14.0.30704.0
- PackageIdentifier: Microsoft.UI.Xaml.2.7
MinimumVersion: 7.2208.15002.0
|
As the maintainer, I'm content to let this one pass un-merged. We've superseded it, and it's available via other channels. :) |
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow