Skip to content

Microsoft.WindowsTerminal version 1.17.11461.0#108350

Closed
DHowett wants to merge 1 commit intomicrosoft:masterfrom
DHowett:autogenerated/Microsoft.WindowsTerminal/9f3cb32e-9bc8-4571-9496-c678b735465a
Closed

Microsoft.WindowsTerminal version 1.17.11461.0#108350
DHowett wants to merge 1 commit intomicrosoft:masterfrom
DHowett:autogenerated/Microsoft.WindowsTerminal/9f3cb32e-9bc8-4571-9496-c678b735465a

Conversation

@DHowett
Copy link
Member

@DHowett DHowett commented May 29, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 29, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @DHowett,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 29, 2023
@BrandonWanHuanSheng
Copy link
Contributor

BrandonWanHuanSheng commented May 29, 2023

The pull request failed due to Microsoft.UI.Xaml.2.7.
WinGet-2023-05-30-07-34-27.496.log

@microsoft-github-policy-service
Copy link
Contributor

Hello @DHowett,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

Hello @DHowett,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@microsoft-github-policy-service microsoft-github-policy-service bot added No-Recent-Activity No activity has occurred on this work item for seven days. labels Jun 6, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @DHowett,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

Hello @DHowett,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@BrandonWanHuanSheng
Copy link
Contributor

@stephengillie Can you add blocking issue with dependcies? Otherwise, the pull request will closed automatically.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Jun 6, 2023
@stephengillie stephengillie added Blocking-Issue Manifest validation is blocked by a known issue. Dependencies and removed Blocking-Issue Manifest validation is blocked by a known issue. labels Jun 6, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @DHowett,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/dependencySupport

@floh96
Copy link
Contributor

floh96 commented Sep 26, 2023

@stephengillie @DHowett winget 1.6 supports dependencies could this pr be updated?

@DHowett
Copy link
Member Author

DHowett commented Sep 26, 2023

That's great news! Somebody will need to explain how to do that 😄

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 26, 2023
@mdanish-kh
Copy link
Contributor

mdanish-kh commented Sep 26, 2023

IIRC, this depended on WinUI.Xaml version 2.8 correct? 👀

Edit: let's find out i guess

@mdanish-kh
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 26, 2023
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Sep 26, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 26, 2023
@mdanish-kh
Copy link
Contributor

So, looks like it depends on -

  • Microsoft.VCLibs.140.00.UWPDesktop
  • Microsoft.UI.Xaml.2.7

Looks like we need to add VCLibs to the repository first. We already have WinUI Xaml 2.7 in the repo.

@DHowett
Copy link
Member Author

DHowett commented Sep 26, 2023

Honestly, we might just want to skip this version. It is the last version that requires the UWPDesktop VCLibs package.

The version that is available online is--regrettably--insanely out of date. They will not release an updated version.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 26, 2023
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2023-09-26 11:58:00.209 [CLI ] Completed installer selection.
2023-09-26 11:58:01.068 [CLI ] Installer hash verified
2023-09-26 11:58:01.178 [CORE] Starting RequestAddPackageAsync operation #0: https://github.com/microsoft/terminal/releases/download/v1.17.11461.0/Microsoft.WindowsTerminal_1.17.11461.0_8wekyb3d8bbwe.msixbundle
2023-09-26 11:58:01.183 [CORE] Begin waiting for operation #0
2023-09-26 11:58:01.183 [CORE] Begin blocking for operation #0
2023-09-26 11:58:03.021 [CORE] Deployment operation #0: Windows cannot install package Microsoft.WindowsTerminal_1.17.11461.0_x64__8wekyb3d8bbwe because this package depends on a framework that could not be found. Provide the framework "Microsoft.UI.Xaml.2.7" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version 7.2208.15002.0, along with this package to install. The frameworks with name "Microsoft.UI.Xaml.2.7" currently installed are: {Microsoft.UI.Xaml.2.7_7.2109.13004.0_x64__8wekyb3d8bbwe}
2023-09-26 11:58:03.021 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(161)\WindowsPackageManager.dll!00007FFDF57B9A45: (caller: 00007FFDF5743515) Exception(1) tid(1998) 80073CF3 Package failed updates, dependency or conflict validation.


2023-09-26 11:58:03.022 [CORE] Starting RemovePackage operation #1: Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe
2023-09-26 11:58:03.033 [CORE] Begin waiting for operation #1
2023-09-26 11:58:03.033 [CORE] Begin blocking for operation #1
2023-09-26 11:58:04.414 [CORE] Deployment operation #1: Windows cannot remove Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe because the current user does not have that package installed. Use Get-AppxPackage to see the list of packages installed.
2023-09-26 11:58:04.414 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFDF57B8724: (caller: 00007FFDF57B9DFC) Exception(2) tid(1998) 80073CF1 Package was not found.

    Msg:[Operation failed: Windows cannot remove Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe because the current user does not have that package installed. Use Get-AppxPackage to see the list of packages installed.] 

2023-09-26 11:58:04.414 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(126)\WindowsPackageManager.dll!00007FFDF593F371: (caller: 00007FFDF57BB123) LogHr(1) tid(1998) 80073CF1 Package was not found.

    Msg:[D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFDF57B8724: (caller: 00007FFDF57B9DFC) Exception(2) tid(1998) 80073CF1 Package was not found.

    Msg:[Operation failed: Windows cannot remove Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe because the current user does not have that package installed. Use Get-AppxPackage to see the list of packages installed.] 
] 

2023-09-26 11:58:04.419 [CLI ] MSIX installer failed: 2147958003
2023-09-26 11:58:04.421 [CLI ] Terminating context: 0x8a150104 at D:\a\_work\1\s\external\pkg\src\AppInstallerCLICore\Workflows\InstallFlow.cpp:1bc

@mdanish-kh
Copy link
Contributor

Automatic Validation ended with:

2023-09-26 11:58:00.209 [CLI ] Completed installer selection.
2023-09-26 11:58:01.068 [CLI ] Installer hash verified
2023-09-26 11:58:01.178 [CORE] Starting RequestAddPackageAsync operation #0: https://github.com/microsoft/terminal/releases/download/v1.17.11461.0/Microsoft.WindowsTerminal_1.17.11461.0_8wekyb3d8bbwe.msixbundle
2023-09-26 11:58:01.183 [CORE] Begin waiting for operation #0
2023-09-26 11:58:01.183 [CORE] Begin blocking for operation #0
2023-09-26 11:58:03.021 [CORE] Deployment operation #0: Windows cannot install package Microsoft.WindowsTerminal_1.17.11461.0_x64__8wekyb3d8bbwe because this package depends on a framework that could not be found. Provide the framework "Microsoft.UI.Xaml.2.7" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version 7.2208.15002.0, along with this package to install. The frameworks with name "Microsoft.UI.Xaml.2.7" currently installed are: {Microsoft.UI.Xaml.2.7_7.2109.13004.0_x64__8wekyb3d8bbwe}
2023-09-26 11:58:03.021 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(161)\WindowsPackageManager.dll!00007FFDF57B9A45: (caller: 00007FFDF5743515) Exception(1) tid(1998) 80073CF3 Package failed updates, dependency or conflict validation.


2023-09-26 11:58:03.022 [CORE] Starting RemovePackage operation #1: Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe
2023-09-26 11:58:03.033 [CORE] Begin waiting for operation #1
2023-09-26 11:58:03.033 [CORE] Begin blocking for operation #1
2023-09-26 11:58:04.414 [CORE] Deployment operation #1: Windows cannot remove Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe because the current user does not have that package installed. Use Get-AppxPackage to see the list of packages installed.
2023-09-26 11:58:04.414 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFDF57B8724: (caller: 00007FFDF57B9DFC) Exception(2) tid(1998) 80073CF1 Package was not found.

    Msg:[Operation failed: Windows cannot remove Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe because the current user does not have that package installed. Use Get-AppxPackage to see the list of packages installed.] 

2023-09-26 11:58:04.414 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(126)\WindowsPackageManager.dll!00007FFDF593F371: (caller: 00007FFDF57BB123) LogHr(1) tid(1998) 80073CF1 Package was not found.

    Msg:[D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFDF57B8724: (caller: 00007FFDF57B9DFC) Exception(2) tid(1998) 80073CF1 Package was not found.

    Msg:[Operation failed: Windows cannot remove Microsoft.WindowsTerminal_3001.17.11461.0_neutral_~_8wekyb3d8bbwe because the current user does not have that package installed. Use Get-AppxPackage to see the list of packages installed.] 
] 

2023-09-26 11:58:04.419 [CLI ] MSIX installer failed: 2147958003
2023-09-26 11:58:04.421 [CLI ] Terminating context: 0x8a150104 at D:\a\_work\1\s\external\pkg\src\AppInstallerCLICore\Workflows\InstallFlow.cpp:1bc

Yep - I was going to suggest the dependency once #120905 gets merged

@mdanish-kh
Copy link
Contributor

Honestly, we might just want to skip this version. It is the last version that requires the UWPDesktop VCLibs package.

The version that is available online is--regrettably--insanely out of date. They will not release an updated version.

Since you're the publisher - that's completely up to you 😄

- silent
Commands:
- wt
PackageFamilyName: Microsoft.WindowsTerminal_8wekyb3d8bbwe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageFamilyName: Microsoft.WindowsTerminal_8wekyb3d8bbwe
PackageFamilyName: Microsoft.WindowsTerminal_8wekyb3d8bbwe
Dependencies:
PackageDependencies:
- PackageIdentifier: Microsoft.UI.Xaml.2.7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a sandbox environment, this package also requires VCLibs. We would have to do something like

Dependencies:
  PackageDependencies:
  - PackageIdentifier: Microsoft.VCLibs.Desktop.14
    MinimumVersion: 14.0.30704.0
  - PackageIdentifier: Microsoft.UI.Xaml.2.7
    MinimumVersion: 7.2208.15002.0

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 27, 2023
@DHowett DHowett closed this Sep 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Sep 28, 2023
@DHowett
Copy link
Member Author

DHowett commented Sep 28, 2023

As the maintainer, I'm content to let this one pass un-merged. We've superseded it, and it's available via other channels. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants