Skip to content

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented May 29, 2023

Pull request has been created with Komac v1.6.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label May 29, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @eitsupi,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@microsoft-github-policy-service
Copy link
Contributor

Hello @eitsupi,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels May 29, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 29, 2023
@stephengillie
Copy link
Collaborator

This package is expecting arguments:

RIG -- The R Installation Manager 0.5.3
NAME
    rig - manage R installations

DESCRIPTION
    rig manages your R installations, on macOS, Windows, and Linux. It can
    install and set up multiple versions of R, and make sure that they work
    together.

    rig is currently experimental and is a work in progress. Feedback is much
    appreciated. See https://github.com/r-lib/rig for bug reports.
...

Also, the Start menu shortcut appears to do nothing - a window pops up and immediately closes. Is that expected?

@eitsupi
Copy link
Contributor Author

eitsupi commented May 31, 2023

Hi @stephengillie, thanks for your review!

This package is expecting arguments:

It is not clear to me what you mean by this point of yours.
Do I need to update the manifest to state something?

Also, the Start menu shortcut appears to do nothing - a window pops up and immediately closes. Is that expected?

This is unrelated behavior to winget, but as you point out, I don't think it's ideal.
I created an issue r-lib/rig#160.
In other words, this is the expected behavior for this version.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 31, 2023
@stephengillie
Copy link
Collaborator

Hi @stephengillie, thanks for your review!

This package is expecting arguments:

It is not clear to me what you mean by this point of yours. Do I need to update the manifest to state something?

The package might need a Command: or similar field added to the manifest in the future. I haven't had an opportunity to learn the exact fix for this situation, but felt that notes like these might help to explain why the error label was removed or waivered. I didn't mean to disturb or insult, and can avoid posting these in your PRs if you would like.

Also, the Start menu shortcut appears to do nothing - a window pops up and immediately closes. Is that expected?

This is unrelated behavior to winget, but as you point out, I don't think it's ideal. I created an issue r-lib/rig#160. In other words, this is the expected behavior for this version.

Thank you for confirming the expected behavior.

@stephengillie stephengillie self-assigned this May 31, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 31, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 31, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 31, 2023 16:57
@microsoft-github-policy-service
Copy link
Contributor

eitsupi,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 6697862 into microsoft:master Jun 1, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello eitsupi,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 1, 2023

The package might need a Command: or similar field added to the manifest in the future. I haven't had an opportunity to learn the exact fix for this situation, but felt that notes like these might help to explain why the error label was removed or waivered.

That makes sense.
I just wanted to know what needed to be changed and I don't care. Thanks for taking a look at this!

@eitsupi eitsupi deleted the Posit.rig-0.5.3-296715693CFB356F020A935697986C51 branch June 2, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants