Skip to content

ES-DE.EmulationStation-DE version 2.0.1#107333

Merged
microsoft-github-policy-service[bot] merged 3 commits intomicrosoft:masterfrom
superusercode:autogenerated/ES-DE.EmulationStation-DE/97b43d14-7b44-4a18-a046-e937bbc9a92f
Jul 2, 2023
Merged

ES-DE.EmulationStation-DE version 2.0.1#107333
microsoft-github-policy-service[bot] merged 3 commits intomicrosoft:masterfrom
superusercode:autogenerated/ES-DE.EmulationStation-DE/97b43d14-7b44-4a18-a046-e937bbc9a92f

Conversation

@superusercode
Copy link
Copy Markdown
Contributor

@superusercode superusercode commented May 19, 2023 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented May 19, 2023

Service Badge  Service Badge  

@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented May 19, 2023

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@superusercode
Copy link
Copy Markdown
Contributor Author

superusercode commented May 19, 2023

This is a fork of EmulationStation, and not the same thing.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels May 19, 2023
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service bot commented May 19, 2023

Hello @superusercode,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 19, 2023
@superusercode
Copy link
Copy Markdown
Contributor Author

superusercode commented May 19, 2023

image
needs a waiver?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 19, 2023
@stephengillie
Copy link
Copy Markdown
Collaborator

stephengillie commented May 19, 2023

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented May 19, 2023

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 19, 2023
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 19, 2023
@superusercode @stephengillie
Update manifests/e/ES-DE/EmulationStation-DE/2.0.1/ES-DE.EmulationSta…
8513387 
…tion-DE.locale.en-US.yaml

Co-authored-by: Stephen Gillie <[email protected]>
@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented May 19, 2023

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 19, 2023
@superusercode
Copy link
Copy Markdown
Contributor Author

superusercode commented Jun 29, 2023

still happen under a win11 vm?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jun 29, 2023
@stephengillie
Copy link
Copy Markdown
Collaborator

stephengillie commented Jun 30, 2023

still happen under a win11 vm?

Yes, in the first attempt. This second attempt was a re-run after re-adding Windows 10 to the Manual Validation pipeline.

@stephengillie
Copy link
Copy Markdown
Collaborator

stephengillie commented Jun 30, 2023

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented Jun 30, 2023

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jun 30, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 30, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) June 30, 2023 21:25
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service bot commented Jun 30, 2023

superusercode,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 2, 2023
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service bot commented Jul 2, 2023

Hello superusercode,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f060105 into microsoft:master Jul 2, 2023
@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented Jul 2, 2023

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@superusercode superusercode deleted the autogenerated/ES-DE.EmulationStation-DE/97b43d14-7b44-4a18-a046-e937bbc9a92f branch July 4, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephengillie stephengillie stephengillie left review comments

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

+1 more reviewer

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Domain

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@superusercode @wingetbot @stephengillie @Trenly @ItzLevvie @JohnMcPMS @zachcarp @yao-msft