Retry sync fork on failure #597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #502 (comment), I thought we did retry on a sync fork failure, but after looking at the code again, it appears we don't. This change makes it so that we attempt to sync fork multiple times if the first attempt fails for any reason. Doing this as it appears users are running into this issue even with the changes made in #581 (but can't confirm if they are in fact using the latest version). I think it's generally better if we attempt retries on sync fork step.
Validation
Validated manually by setting response to have a 422 status code (to throw a GenericSyncForkException) in
UpdateForkedRepoWithUpstreamCommitsfunction asMicrosoft Reviewers: Open in CodeFlow