Handle sync fork failures with useful error messages #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
a team and
yao-msft
and removed request for
a team
Contributor
Author
|
@denelon Not sure when we're planning to make a new winget-create release with the |
Collaborator
|
I don't anticipate deprecating token too soon. We have lots of CI/CD things out there that are using "--token". We need to be very mindful before we break anything. |
Contributor
Author
|
I don't think the way it's implemented will break any existing CI/CD scenarios though. It'll just display a warning, which would be the cue for publishers to migrate to the environment variable |
|
Thanks for adding this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Octokit.ApiExceptionerror when creating pull request #522 (comment)When we have a failure while syncing fork, show useful messages to the user
Microsoft Reviewers: Open in CodeFlow