Don't set ARP entries in NewCommand flow #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
a team,
ryfu-msft and
yao-msft
and removed request for
a team
AmelBawa-msft
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #550 which allowed the CLI to parse & update ARP entries. PR was intended for UpdateCommand as it had guards to not include / update ARP entries if they didn't exist in the existing manifest, but also affected the NewCommand flow.
The general community opinion is that ARP entries should not be set when it's not needed as there have been incidents where bad ARP values can cause the publish pipeline to break, and also the CLI matching can be affected if bad values (especially
DisplayVersion) get set. I believe they shouldn't be set in NewCommand flow as it makes the manifest more complex for new contributors (without any real benefit) and can be problematic if bad values get setValidation
Test with a manual example
Microsoft Reviewers: Open in CodeFlow