Skip to content

Improve the MakeDSC script #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryfu-msft merged 16 commits into from
Dec 4, 2023
Merged

Improve the MakeDSC script #488

ryfu-msft merged 16 commits into from
Dec 4, 2023

Conversation

@Trenly
Copy link
Contributor

@Trenly Trenly commented Dec 2, 2023 •
edited by microsoft-github-policy-service bot
Loading

  • Addresses most of @mdanish-kh 's comments in Prototype creating a WinGet Configuration DSC file in PowerShell #462
  • Throws custom error type for missing dependencies
  • Writes DSC schema header in output file
  • Removes regex for source by using the selected package directly
  • Allows selection of package by ID, Name, or Index
  • Allows skipping package selection in case of a bad query
  • Removes for-loop displaying the package output and uses the pipeline instead

cc @KevinLaMS

Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested review from a team, ryfu-msft and yao-msft and removed request for a team December 2, 2023 20:00
mdanish-kh
mdanish-kh reviewed Dec 2, 2023
View reviewed changes
mdanish-kh
mdanish-kh approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#488 (comment) would need to be looked into by a maintainer

@ryfu-msft
Copy link
Contributor

ryfu-msft commented Dec 4, 2023

@Trenly, can you move the location of this script to Tools/WingetCreateMakeDSC.ps1 instead of src/Prototype/WingetCreateMakeDSC.ps1. This doesn't really relate to WingetCreate right now so I'd like to keep it separate from the src folder. Everything else looks good to me 😄

@Trenly
Copy link
Contributor Author

Trenly commented Dec 4, 2023

@Trenly, can you move the location of this script to Tools/WingetCreateMakeDSC.ps1 instead of src/Prototype/WingetCreateMakeDSC.ps1. This doesn't really relate to WingetCreate right now so I'd like to keep it separate from the src folder. Everything else looks good to me 😄

@ryfu-msft - I can, but I would rather let @KevinLaMS do that in his branch just to avoid any merge conflicts. This PR merges into his draft PR and not into Main

@ryfu-msft ryfu-msft merged commit a316bf7 into microsoft:MakeDSC Dec 4, 2023
@Trenly Trenly deleted the ImproveMakeDSC branch December 4, 2023 21:58
@KevinLaMS
Copy link
Contributor

KevinLaMS commented Dec 4, 2023

@Trenly @mdanish-kh @ryfu-msft
Thank you so much for helping get this tool out.
@denelon Would you mind tweeting about the tool, letting people know it is an easy way to quickly create configuration files for winget apps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yao-msft yao-msft Awaiting requested review from yao-msft

@ryfu-msft ryfu-msft Awaiting requested review from ryfu-msft

1 more reviewer

@mdanish-kh mdanish-kh mdanish-kh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trenly @ryfu-msft @KevinLaMS @mdanish-kh