This repository was archived by the owner on Mar 4, 2025. It is now read-only.
When cold starting on Win10 with multi monitors, starts basically invisible#46
Closed
tig wants to merge 3 commits intomicrosoft:masterfrom
Closed
When cold starting on Win10 with multi monitors, starts basically invisible#46tig wants to merge 3 commits intomicrosoft:masterfrom
tig wants to merge 3 commits intomicrosoft:masterfrom
Conversation
… with 0 height, CW_DEFAULT width window)
Contributor
|
Hey Charlie, I thought I tested that, but glad it was a simple fix. Can you revert the change to .gitignore? I'll merge your request after that. |
Author
|
Sorry, my git skillz are lame. I couldn't figure out how to revert the .gitignore change (I actually thought I had reverted it before the pull request). I just copied the original over my edited version and added/commited that. |
|
@tig to revert a commit, from the command line, you run hope it helps in the future :) |
craigwi
added a commit
that referenced
this pull request
Apr 11, 2018
Contributor
|
Right fix is more complicated. See my change. Thanks Charlie! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found on two different Win10 machines with multi-mon, the first time I ran winfile.exe the window was basically just the title bar (zero height client area) and infinitely wide (actually 0x80000000)).
This one line I removed is the cause and I can't see why it would be needed. SystemParametersInfo(SPI_GETWORKAREA) returns the correct RECT.
Did not test on any version of Windows other than Win10...