This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Fix calling convention for WNet function pointers#192
Merged
craigwi merged 1 commit intomicrosoft:masterfrom Jul 27, 2018
carlo-bramini:master
Merged
Fix calling convention for WNet function pointers#192craigwi merged 1 commit intomicrosoft:masterfrom carlo-bramini:master
craigwi merged 1 commit intomicrosoft:masterfrom
carlo-bramini:master
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to compile latest WinFile with a project created by me and I got a crash immediately after the application was started: in my opinion, this happened because the pointers to WNet functions are not declared for using __stdcall calling convention.
After doing the fix described in this PR, the issue disappeared.
The bug could be also by-passed by forcing default calling convention to __stdcall, but in this way the code looks more correct.
Sincerely.