Conversation
This was referenced Feb 18, 2022
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They're finally here! While the Win32 metadata lacks explicit types for
PCSTRandPCWSTR, the metadata gives enough clues as to when they would have existed in the original APIs and mymetadatacrate now reconstructs that type information. As a result, thewindowsandwindows-syscrates can now offer first-classPCSTRandPCWSTRtypes, alongsidePSTRandPWSTR, thus makingconst-correct Win32 programming far more natural in Rust.As these types are synthesized and highly specialized, I've moved them into the
windows::coreandwindows_sys::coremodules respectively.Fixes #1496, fixes #1504