Conversation
This was referenced Nov 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzing compile time indicates that most of the time building the
windowscrate is spent parsing function bodies. Those functions provide support for a more idiomatic developer experience. Even though those function bodies essentially compile away to nothing, the extra compile time makes adoption of thewindowscrate prohibitive in some cases. Thewindows-syscrate will simply have function declarations (externs), structs, and constants, and not include any function bodies. This is essentially the underlying ABI for the Windows API.Today, the
windowscrate "inlines" this ABI and hides it from the developer. With the introduction of thewindows-syscrate, thewindowscrate will instead defer to thewindows-syscrate for those declarations. A developer can then choose to use thewindowscrate directly for convenience, safety, and productivity, or use the underlyingwindows-syscrate for no-compromise compile time when that matters most.As always, all declarations will be generated from metadata. This PR just adds the basic scaffolding. Splitting out the ABI code gen is next.