fix: expose MCP mock tools to Copilot CLI#441
Merged
Conversation
Co-authored-by: Copilot App <[email protected]> Copilot-Session: 6a31c0d0-d139-415f-9f2b-33de69a5b011
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Copilot SDK evaluations that use mcp_mocks by ensuring the generated Copilot CLI MCP server configuration includes an explicit tool allowlist, preventing the bundled CLI from skipping otherwise-valid mock servers (per #440).
Changes:
- Add
tools: ["*"]to the generated Copilot SDK stdio server config formcp_mocks. - Add a regression test asserting the generated mock server config includes the tool allowlist.
- Update docs (README + eval-yaml guide) and prepare the 0.38.3 changelog entry describing the behavior.
Show a summary per file
| File | Description |
|---|---|
| site/src/content/docs/guides/eval-yaml.mdx | Documents that mcp_mocks automatically expose their declared tools to the Copilot CLI (no separate allowlist needed). |
| README.md | Mirrors the mcp_mocks tool exposure documentation in the main README. |
| internal/copilotconfig/mcp.go | Ensures mock stdio server configs include Tools: []string{"*"} so the bundled CLI accepts them. |
| internal/copilotconfig/mcp_test.go | Adds regression coverage asserting stdio.Tools is set to ["*"] for mocks. |
| CHANGELOG.md | Adds a 0.38.3 entry and updates compare links accordingly. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #440
Summary
mcp_mocksstdio servers with the explicit Copilot CLItools: ["*"]allowlistValidation
go test ./...cd site && npm ci --no-audit --no-fund && npm run buildRubber-duck review: no blocking concerns.