Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Apr 13, 2023

Description

Fix nullability error in DotnetTestManager that is breaking sourcebuild in dotnet/installer with the latest versions of vstest

Related issue

fixes #4394
dotnet/installer#16005 (comment)

  • I have ensured that there is a previously discussed and approved issue.

@lewing
Copy link
Member Author

lewing commented Apr 13, 2023

@mmitche
Copy link
Member

mmitche commented Apr 14, 2023

@nohwnd PTAL

@lewing
Copy link
Member Author

lewing commented Apr 14, 2023

is it one of the things blocking dotnet/installer#16033 which is what updates the dotnet sdk

@nohwnd nohwnd merged commit 1541fc3 into microsoft:main Apr 14, 2023
@lewing lewing deleted the lewing/fix-nullablility branch April 14, 2023 18:43
This was referenced Jul 22, 2025
This was referenced Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest vstest builds do not build in sourcebuild with nullability enabled

3 participants