Revert removal of Video Recorder#15336
Conversation
|
@copilot can you add an integration test that will use the data collector (use the example in the added MD file), and then check in TestResults folder for presence of non-empty .wmv file. This is a windows only tool, so make the test windows only. |
|
Don't close this. I will get back to it. |
microsoft-github-policy-service
Bot
added
Needs: Attention 👋
and removed
State: No Recent Activity
Needs: Author Feedback
labels
There was a problem hiding this comment.
Pull request overview
Restores the Video and Voice Recorder data collector artifacts into the VSTest VSIX and Microsoft.TestPlatform NuGet package after they were removed unintentionally during TPv0 cleanup.
Changes:
- Re-add VideoRecorder extension content to the VSIX packaging inputs.
- Add VideoRecorder binaries to
Microsoft.TestPlatform.nuspecand update package verification to account for the new exe. - Add documentation explaining how to use the Video and Voice Recorder data collector.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/package/Microsoft.VisualStudio.TestTools.TestPlatform.V2.CLI/Microsoft.VisualStudio.TestTools.TestPlatform.V2.CLI.csproj | Includes VideoRecorder extension folder in the VSIX packaging inputs. |
| src/package/Microsoft.TestPlatform/Microsoft.TestPlatform.nuspec | Packages VideoRecorder engine/exe and related assemblies into the NuGet tools layout. |
| eng/verify-nupkgs.ps1 | Updates NuPkg verification (file count + exe arch list) for the added VideoRecorder payload. |
| docs/extensions/video-and-voice-recorder.md | Documents usage and shipped file layout for the Video/Voice recorder collector. |
|
Test is added. |
|
|
||
| if (_useVsixRunner) | ||
| { | ||
| var runnerInfo = new RunnerInfo |
There was a problem hiding this comment.
I want to refine this later, the runner info is not super informative about what is being run.
Description
Puts back Video and Voice Recorder data collector for VSTest that was incorrectly removed as part of TPv0 removal.
Related issue
Fix #15292