Skip to content

Commit ddda590

Browse files
nohwnddotnet-maestro[bot]Sanan07jakubch1cvpoienaru
authored
Improve blame (#2552)
* Hide -release in console * Add param block * Match on whole branch name * Set var * Change assertion * Trim version * Update dependencies from https://github.com/dotnet/arcade build 20200602.3 (#2456) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 5.0.0-beta.20052.1 -> To Version 1.0.0-beta.20302.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update feeds * Revert to previous dotnet version * Added new exception handling (#2461) * Test space added * Exception handler was added to catch AccessDeniedException while trying to create TestResults folder * Remove unnecessary space * Deleted unnecessary test. Changed console message and corrected folder path in that message * Remove unnecessary dot * Removed unnecessary lines and usings and coreccted exception message * Removed unnecessary line * Updating resource files * New exception handling was added * Formatted exception message * Adding test run attachments processing (#2463) * v1 * Merging v1 * Rename to MultiTestRunsFinalization * New version * More changes * More changes * Next changes * Fix * test * More changes * Dmc chagnes * next * small changes * compiled * More changes * acceptance tests green * Review comments #1 * Resolving more comments * Tests for design mode client * Tests for events handler * revert not related changes * More changes * Compiling OK, tests OK * Unit tests for manager * More changes * More tests * tests for reqeust sender * more tests * Tests for cancelling * Acceptance tests done * Remove not used stuff * Fix comments * Fix race condition in test * Fix another race condition * Fix converting to xml * fix next test * fix test * Next changes * Review changes #1 * Fixing multi test finalization manager tests * Fixes * Fix last unit test * Fix acceptance tests * Progress feature, compiling + unit tests * acceptance tests changes * More changes * Fixing resources accesability * Fix test * Fix race conditions in acceptance tests * RFC changes merged * Log warning in case of unexpected message id * Fix spelling * Additional comment * Restore some stuff in interfaces * Big renaming * Added processingSettings * Fix naming * Move explanation to <remarks> * Add environment variables to enable MacOS dump * Fixed code coverage compatibility issue (#2527) Fixed code coverage compatibility issue * Print version of the product in log (#2535) * Trigger dumps asynchronously (#2533) * Run each dump in a task in netclient dumper * More reasonable timeout * Revert "Trigger dumps asynchronously (#2533)" (#2541) This reverts commit 3454261. * Remove env variables * Remove sleeps and extra process dumps from blame * Update message and remove delays Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Sanan Yuzbashiyev <[email protected]> Co-authored-by: Jakub Chocholowicz <[email protected]> Co-authored-by: Codrin-Victor Poienaru <[email protected]>
1 parent 327c428 commit ddda590

File tree

20 files changed

+95
-52
lines changed

20 files changed

+95
-52
lines changed

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/BlameLogger.cs‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,13 @@ private void TestRunCompleteHandler(object sender, TestRunCompleteEventArgs e)
112112
return;
113113
}
114114

115-
this.output.Error(false, Resources.Resources.AbortedTestRun);
116-
117115
StringBuilder sb = new StringBuilder();
118116
foreach (var tcn in testCaseNames)
119117
{
120118
sb.Append(tcn).Append(Environment.NewLine);
121119
}
122120

123-
this.output.Error(false, sb.ToString());
121+
this.output.Error(false, Resources.Resources.AbortedTestRun, sb.ToString());
124122
}
125123

126124
#endregion

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/Resources.Designer.cs‎

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/Resources.resx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,11 @@
118118
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119119
</resheader>
120120
<data name="AbortedTestRun" xml:space="preserve">
121-
<value>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</value>
121+
<value>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
122+
The test running when the crash occurred:
123+
{0}
124+
This test may, or may not be the source of the crash.</value>
125+
<comment>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</comment>
122126
</data>
123127
<data name="BlameParameterKeyIncorrect" xml:space="preserve">
124128
<value>The blame parameter key specified {0} is not valid. Ignoring this key.</value>

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/xlf/Resources.cs.xlf‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
</header>
2222
<body>
2323
<trans-unit id="AbortedTestRun">
24-
<source>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</source>
25-
<target state="translated">Aktivní testovací běh byl přerušen, protože hostitelský proces byl neočekávaně ukončen při provádění následujících testů:</target>
26-
<note />
24+
<source>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
25+
The test running when the crash occurred:
26+
{0}
27+
This test may, or may not be the source of the crash.</source>
28+
<target state="new">Aktivní testovací běh byl přerušen, protože hostitelský proces byl neočekávaně ukončen při provádění následujících testů:</target>
29+
<note>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</note>
2730
</trans-unit>
2831
<trans-unit id="ProcDumpEnvVarEmpty">
2932
<source>Required environment variable PROCDUMP_PATH was null or empty. Set PROCDUMP_PATH to path of folder containing appropriate procdump executable.</source>

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/xlf/Resources.de.xlf‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
</header>
2222
<body>
2323
<trans-unit id="AbortedTestRun">
24-
<source>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</source>
25-
<target state="translated">Der aktive Testlauf wurde abgebrochen, weil der Hostprozess beim Ausführen der folgenden Tests unerwartet beendet wurde:</target>
26-
<note />
24+
<source>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
25+
The test running when the crash occurred:
26+
{0}
27+
This test may, or may not be the source of the crash.</source>
28+
<target state="new">Der aktive Testlauf wurde abgebrochen, weil der Hostprozess beim Ausführen der folgenden Tests unerwartet beendet wurde:</target>
29+
<note>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</note>
2730
</trans-unit>
2831
<trans-unit id="ProcDumpEnvVarEmpty">
2932
<source>Required environment variable PROCDUMP_PATH was null or empty. Set PROCDUMP_PATH to path of folder containing appropriate procdump executable.</source>

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/xlf/Resources.es.xlf‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
</header>
2222
<body>
2323
<trans-unit id="AbortedTestRun">
24-
<source>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</source>
25-
<target state="translated">La serie de pruebas activa se anuló porque el proceso del host se cerró inesperadamente al ejecutar las pruebas siguientes:</target>
26-
<note />
24+
<source>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
25+
The test running when the crash occurred:
26+
{0}
27+
This test may, or may not be the source of the crash.</source>
28+
<target state="new">La serie de pruebas activa se anuló porque el proceso del host se cerró inesperadamente al ejecutar las pruebas siguientes:</target>
29+
<note>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</note>
2730
</trans-unit>
2831
<trans-unit id="ProcDumpEnvVarEmpty">
2932
<source>Required environment variable PROCDUMP_PATH was null or empty. Set PROCDUMP_PATH to path of folder containing appropriate procdump executable.</source>

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/xlf/Resources.fr.xlf‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
</header>
2222
<body>
2323
<trans-unit id="AbortedTestRun">
24-
<source>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</source>
25-
<target state="translated">La série de tests active a été abandonnée, car le processus hôte s'est arrêté de manière inattendue durant l'exécution du ou des tests suivants :</target>
26-
<note />
24+
<source>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
25+
The test running when the crash occurred:
26+
{0}
27+
This test may, or may not be the source of the crash.</source>
28+
<target state="new">La série de tests active a été abandonnée, car le processus hôte s'est arrêté de manière inattendue durant l'exécution du ou des tests suivants :</target>
29+
<note>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</note>
2730
</trans-unit>
2831
<trans-unit id="ProcDumpEnvVarEmpty">
2932
<source>Required environment variable PROCDUMP_PATH was null or empty. Set PROCDUMP_PATH to path of folder containing appropriate procdump executable.</source>

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/xlf/Resources.it.xlf‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
</header>
2222
<body>
2323
<trans-unit id="AbortedTestRun">
24-
<source>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</source>
25-
<target state="translated">L'esecuzione dei test attiva è stata interrotta perché il processo host è stato terminato in modo imprevisto durante l'esecuzione del test o dei test seguenti:</target>
26-
<note />
24+
<source>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
25+
The test running when the crash occurred:
26+
{0}
27+
This test may, or may not be the source of the crash.</source>
28+
<target state="new">L'esecuzione dei test attiva è stata interrotta perché il processo host è stato terminato in modo imprevisto durante l'esecuzione del test o dei test seguenti:</target>
29+
<note>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</note>
2730
</trans-unit>
2831
<trans-unit id="ProcDumpEnvVarEmpty">
2932
<source>Required environment variable PROCDUMP_PATH was null or empty. Set PROCDUMP_PATH to path of folder containing appropriate procdump executable.</source>

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/xlf/Resources.ja.xlf‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
</header>
2222
<body>
2323
<trans-unit id="AbortedTestRun">
24-
<source>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</source>
25-
<target state="translated">以下のテストの実行中にホスト プロセスが予期せず終了したため、アクティブなテスト実行が中止されました:</target>
26-
<note />
24+
<source>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
25+
The test running when the crash occurred:
26+
{0}
27+
This test may, or may not be the source of the crash.</source>
28+
<target state="new">以下のテストの実行中にホスト プロセスが予期せず終了したため、アクティブなテスト実行が中止されました:</target>
29+
<note>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</note>
2730
</trans-unit>
2831
<trans-unit id="ProcDumpEnvVarEmpty">
2932
<source>Required environment variable PROCDUMP_PATH was null or empty. Set PROCDUMP_PATH to path of folder containing appropriate procdump executable.</source>

‎src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Resources/xlf/Resources.ko.xlf‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
</header>
2222
<body>
2323
<trans-unit id="AbortedTestRun">
24-
<source>The active Test Run was aborted because the host process exited unexpectedly while executing following test(s):</source>
25-
<target state="translated">다음 테스트를 실행하는 동안 호스트 프로세스가 예기치 않게 종료되어 활성 테스트 실행이 중단되었습니다.</target>
26-
<note />
24+
<source>The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
25+
The test running when the crash occurred:
26+
{0}
27+
This test may, or may not be the source of the crash.</source>
28+
<target state="new">다음 테스트를 실행하는 동안 호스트 프로세스가 예기치 않게 종료되어 활성 테스트 실행이 중단되었습니다.</target>
29+
<note>{0} is a single test (or in rare cases multiple tests) that were running when test host crashed.</note>
2730
</trans-unit>
2831
<trans-unit id="ProcDumpEnvVarEmpty">
2932
<source>Required environment variable PROCDUMP_PATH was null or empty. Set PROCDUMP_PATH to path of folder containing appropriate procdump executable.</source>

0 commit comments

Comments
 (0)