[rel/17.6] Disable pre-start of testhosts (#4554)

nohwnd · web-flow · commit bda2d1e387c4 · 2023-06-15T20:28:17.000+02:00
diff --git a/src/Microsoft.TestPlatform.CrossPlatEngine/Client/Parallel/ParallelOperationManager.cs b/src/Microsoft.TestPlatform.CrossPlatEngine/Client/Parallel/ParallelOperationManager.cs
@@ -17,7 +17,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client;
 /// </summary>
 internal sealed class ParallelOperationManager<TManager, TEventHandler, TWorkload> : IDisposable
 {
-    private const int PreStart = 2;
+    private const int PreStart = 0;
     private readonly static int VSTEST_HOSTPRESTART_COUNT =
         int.TryParse(
                 Environment.GetEnvironmentVariable(nameof(VSTEST_HOSTPRESTART_COUNT)),
diff --git a/test/Microsoft.TestPlatform.CrossPlatEngine.UnitTests/Client/Parallel/ParallelProxyExecutionManagerTests.cs b/test/Microsoft.TestPlatform.CrossPlatEngine.UnitTests/Client/Parallel/ParallelProxyExecutionManagerTests.cs
@@ -285,11 +285,7 @@ public void StartTestRunShouldProcessAllSourcesOnExecutionAbortsForAnySource()
 
         Assert.IsTrue(_executionCompleted.Wait(Timeout3Seconds), "Test run not completed.");
 
-        // Even though we start the test run for two sources, because of the current setup where
-        // we initialize a proxy if no more slots are available, we end up with abort notice being
-        // sent only to the running manager. This leaves the initialized manager in limbo and the
-        // assert will fail because of this.
-        Assert.AreEqual(1, _processedSources.Count, "Abort should stop all sources execution.");
+        Assert.AreEqual(2, _processedSources.Count, "Abort should stop all sources execution.");
     }
 
     [TestMethod]

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client;`
`17`	`17`	`/// </summary>`
`18`	`18`	`internal sealed class ParallelOperationManager<TManager, TEventHandler, TWorkload> : IDisposable`
`19`	`19`	`{`
`20`		`- private const int PreStart = 2;`
	`20`	`+ private const int PreStart = 0;`
`21`	`21`	`private readonly static int VSTEST_HOSTPRESTART_COUNT =`
`22`	`22`	`int.TryParse(`
`23`	`23`	`Environment.GetEnvironmentVariable(nameof(VSTEST_HOSTPRESTART_COUNT)),`