Add colors to console messages#324
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Jan 16, 2019
usernamehw:console_colors
Merged
Add colors to console messages#324joaomoreno merged 2 commits intomicrosoft:masterfrom usernamehw:console_colors
joaomoreno merged 2 commits intomicrosoft:masterfrom
usernamehw:console_colors
Conversation
joaomoreno
requested changes
Jan 15, 2019
Member
joaomoreno
left a comment
joaomoreno
left a comment
There was a problem hiding this comment.
We definitely don't want to do this if the output stream isn't a TTY.
I suggest to just depend on chalk or similar.
Contributor
Author
|
Should I bring back |
Member
|
Nah, it's good without. 👍 |
joaomoreno
approved these changes
Jan 16, 2019
Member
joaomoreno
left a comment
joaomoreno
left a comment
There was a problem hiding this comment.
We don't need @types/chalk:
npm WARN deprecated @types/[email protected]: This is a stub types definition for chalk (https://github.com/chalk/chalk). chalk provides its own type definitions, so you don't need @types/chalk installed!
I've also rewritten how the util looks like. I'd rather have functions we can call rather than consts we have to add to strings.
Member
|
Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
Didn't test the message itself on macOS.
Also didn't test it in general since I don't know how.