fix show: add icon fallback on win32#226
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Dec 7, 2017
raix:bug/221-show-fix-star-icons-on-win32
Merged
fix show: add icon fallback on win32#226joaomoreno merged 1 commit intomicrosoft:masterfrom raix:bug/221-show-fix-star-icons-on-win32
joaomoreno merged 1 commit intomicrosoft:masterfrom
raix:bug/221-show-fix-star-icons-on-win32
Conversation
Both cmd and powershell fails to render the super nice unicode stars. It breaks my hearts... to make windows users use a fallback. The issue circles unicode glyphs not in raster etc. fonts and the use of charpages. fixes #221
joaomoreno
approved these changes
Dec 7, 2017
Member
joaomoreno
left a comment
joaomoreno
left a comment
There was a problem hiding this comment.
Yeah that's really too bad!
Member
|
Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both cmd and powershell fails to render the super nice unicode stars. It breaks my hearts... to make windows users use a fallback.
The issue circles unicode glyphs not in raster etc. fonts and the use of charpages.
fixes #221