Feature/issue 214 add show command by raix · Pull Request #215 · microsoft/vscode-vsce

raix · 2017-11-16T22:28:48Z

This pr. contains the initial proposal for a “show” extension metadata command

Usage:

$ vsce show <extensionId>

# or as json

$ vsce show <extensionId> --json

It will grab an available `pat` and query extensio gallary (ro)

Initial version of show command Usage: ```bash $ vsce show gitlens.eamodio # or as json $ vsce show gitlens.eamodio --json ```

msftclas · 2017-11-16T22:28:57Z

All CLA requirements met.

joaomoreno

Overall looks good.

Though it doesn't work for me:

joaomoreno · 2017-11-17T09:18:17Z

src/main.ts

 		.description('Remove a publisher from the known publishers list')
 		.action(name => main(logoutPublisher(name)));

+	program


Let's use extensionid, just like unpublish.

joaomoreno · 2017-11-17T09:19:57Z

src/show.ts

+		ExtensionQueryFlags.IncludeMetadata |
+		ExtensionQueryFlags.IncludeStatistics |
+		ExtensionQueryFlags.IncludeVersions;
+	return getExtension(extensionPublisher, extensionName, undefined, flags)


We gotta do some error handling here.

Something like Extension 'joao' not found would be better.

yeah - also taking into account that it doesn't work for you, would be nice to have more debugging.

@joaomoreno I'm wondering why it errors Invalid Resource could you do npm list vso-node-api to see what version of the api you are on?
(I'm at [email protected])

joaomoreno · 2017-11-17T09:20:54Z

src/show.ts

+export type ViewTable = ViewTableRow[];
+
+export function show(extensionUniqIdentifier: string, json: boolean = false): Promise<any> {
+	const [extensionPublisher, extensionName] = extensionUniqIdentifier.split(/\.(.+)?/, 2);


Kind of a strange regex here. You just need .split('.').

I assumed that name could contain dots, found https://github.com/Microsoft/vscode-vsce/blob/master/src/publish.ts#L185 :)

After second thought, extensionName could have dots - but it would not be valid. eg.: vsce show mortenhenriksen.perl-debug.foo would return the package perl-debug. I've made the extensionId "parsing" more readable so it throws on invalid extension names.

Publishers and extension names can't have dots. 👍 The Marketplace doesn't support it.

* naming consistency "extensionUniqIdentifier" -> "extensionid" * Make extensionid parser more readable

This can happen if access token is invalid/has expired. The solution added in this commit: * Try each available token until success or all failed. Not ideal but we require a PAT since we access `_apis/gallery` and not `_apis/public/gallery/extensionquery`

joaomoreno · 2017-11-17T15:46:28Z

@raix Got the same [email protected] dependency. Hmmm.

raix · 2017-11-17T15:47:52Z

@joaomoreno I've added error handler for the "Invalid Resource" error with the current constraints, would be nice if the public api was available in vso-node-api.

joaomoreno · 2017-11-17T15:58:27Z

Yup, that was it! I had an old access token. Interesting, I wonder if we can get this to work without depending on login.

Love those unicode stars! ★ ★ ★ ★ ★

raix · 2017-11-17T16:14:11Z

We could just make a post call directly to the public api v3.preview

* add minimal `PublicGalleryAPI` * no PAT requirements

It will deprecate in the future + not that useful

raix · 2017-11-17T21:51:46Z

@joaomoreno I've added PublicGalleryAPI this doesn't require a pat, let me know what you think

(one could ague that it belongs in vso-node-api)

also break on more than space

joaomoreno · 2017-11-20T08:36:28Z

Great stuff. Thanks! 🍻

joaomoreno · 2017-11-20T08:38:23Z

@modigrv Is there any way we can use the vso-node-api in an unauthenticated way? I've tried passing a no-op AuthHandler to the WebApi but the extension query request eventually fails while getting versioning data.

raix · 2017-11-20T09:47:57Z

( Currently using the public /_apis/public the /gallery/extensionquery - similar to whats done in vs code)

Morten Henriksen added 2 commits November 16, 2017 23:07

Add "getExtension" to store

f913702

It will grab an available `pat` and query extensio gallary (ro)

Add show command

e88dfcd

Initial version of show command Usage: ```bash $ vsce show gitlens.eamodio # or as json $ vsce show gitlens.eamodio --json ```

raix mentioned this pull request Nov 16, 2017

feature: ability to lookup extension on Marketplace via command line #214

Closed

Correct uniq identifier

2afaa22

joaomoreno added this to the Backlog milestone Nov 17, 2017

joaomoreno self-requested a review November 17, 2017 09:17

joaomoreno self-assigned this Nov 17, 2017

joaomoreno requested changes Nov 17, 2017

View reviewed changes

Morten Henriksen added 3 commits November 17, 2017 14:25

rename to "extensionid"

63b1a27

* naming consistency "extensionUniqIdentifier" -> "extensionid" * Make extensionid parser more readable

Handle more errors

3fb0115

Morten Henriksen added 4 commits November 17, 2017 21:47

Use public gallery api

2c8d8be

* add minimal `PublicGalleryAPI` * no PAT requirements

Add deserializer to extensionQuery

fb58052

Remove extension ID from details

f725247

It will deprecate in the future + not that useful

Remove old "getExtension"

88ff9a0

Morten Henriksen added 3 commits November 18, 2017 07:56

remove extra slash

8efd6b2

Add indent on wordwrap

af273df

also break on more than space

refactor show into viewutils

32c7a0e

raix changed the title ~~WIP: Feature/issue 214 add show command~~ Feature/issue 214 add show command Nov 18, 2017

raix mentioned this pull request Nov 18, 2017

feature: ability to search for extension on Marketplace via command line #216

Closed

joaomoreno merged commit bf162ac into microsoft:master Nov 20, 2017

raix mentioned this pull request Nov 22, 2017

Customize release/publish via plugins semantic-release/semantic-release#484

Closed

joaomoreno mentioned this pull request Dec 4, 2017

Test: VSCE show command microsoft/vscode#39586

Closed

3 tasks

Conversation

raix commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaomoreno left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joaomoreno Nov 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joaomoreno commented Nov 17, 2017

Uh oh!

raix commented Nov 17, 2017

Uh oh!

joaomoreno commented Nov 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raix commented Nov 17, 2017

Uh oh!

raix commented Nov 17, 2017

Uh oh!

joaomoreno commented Nov 20, 2017

Uh oh!

joaomoreno commented Nov 20, 2017

Uh oh!

raix commented Nov 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raix commented Nov 16, 2017 •

edited

Loading

msftclas commented Nov 16, 2017 •

edited

Loading

joaomoreno Nov 17, 2017 •

edited

Loading

joaomoreno commented Nov 17, 2017 •

edited

Loading