Avoid Node.js DEP0190 warning by using string form for prepublish command #1188
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the Node.js
DEP0190deprecation warning:Replaces the deprecated pattern:
with the safe and supported string form:
Why this matters
shell: truewith an argument array triggers a warning and is discouraged.DEP0190 (passing args to spawn with shell: true) isn't fixable when
stdiooption is required nodejs/node#58763Why this is safe
toolvalue is controlled (npmoryarn), no user input is involved.DEP0190warning in all supported Node.js versions.Additional improvements
prepublishvariable for reuse in both logging and execution.