-
Notifications
You must be signed in to change notification settings - Fork 243
Closed
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorfeature-requestRequest for new features or functionalityRequest for new features or functionalityverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
The Regex used for checking valid engine version, can have values like 1.96.x, which is not a valid semver.
When using these kinds of version, the semver version comparison fails.
Lines 51 to 53 in f1fc6d2
| if (!/^\*$|^(\^|>=)?((\d+)|x)\.((\d+)|x)\.((\d+)|x)(\-.*)?$/.test(version)) { | |
| throw new Error(`Invalid vscode engine compatibility version '${version}'`); | |
| } |
Line 506 in f1fc6d2
| if (engineVersion !== 'latest' && !semver.satisfies(engineVersion, '>=1.61', { includePrerelease: true })) { |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorfeature-requestRequest for new features or functionalityRequest for new features or functionalityverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded