@YuichiNukiyama thanks for the PR 💐

@YuichiNukiyama does tslint also support linting of react .jsx files?

@YuichiNukiyama is there a configuration option in tslint.json to enable tslint in .js files? I'm testing it currently, but do not get tslint warnings in .js files

in .ts files

in .js files

@egamma Thanks for merging my PR.

does tslint also support linting of react .jsx files?

TSLint hasn't supported .jsx files yet.

is there a configuration option in tslint.json to enable tslint in .js files?
I'm testing it currently, but do not get tslint warnings in .js files

TSLint have new options. If you want to lint js file, you shoud add jsRules options to tslint.json.

{
  "jsRules": {
    "quotemark": [true, "double", "avoid-escape"]
  },
  "rules": {
    …
  }
}

@YuichiNukiyama thanks I could now test the JS support.

Since JS is now supported, the extension also needs to activate for js files.

    "onLanguage:javascript",

I've pushed the change.

I also noticed that I don't get validation/suggestions inside the jsRules properties.

rules

jsRules

The schema for tslint.json at http://json.schemastore.org/tslint should be updated to include jsRules.

I see. I'll try it.

done 😄

excellent, thanks 🌷

@YuichiNukiyama regarding linting of .jsx files. It looks like this is now supported. Pls see palantir/tslint#1714. It is an easy change to enable tslint for javascriptreact files, what do you think?

I think so, too. I'll send PR.