This repository was archived by the owner on Oct 12, 2022. It is now read-only.
fixed regexp pattern, violated rule was missing#107
Merged
egamma merged 1 commit intomicrosoft:masterfrom Oct 3, 2016
Merged
Conversation
The current regexp pattern does not take the rule name into account which results in file names like the following: `(no-shadowed-variable) src/...`
Member
|
@robstoll thanks for catching this one 🌹 |
robstoll
added a commit
to robstoll/vscode-tslint
that referenced
this pull request
Nov 27, 2016
seems like the rule name is no longer emitted in a newer version of gulp-tslint
robstoll
added a commit
to robstoll/vscode-tslint
that referenced
this pull request
Nov 27, 2016
seems like the rule name is no longer emitted in a newer version of gulp-tslint
egamma
added a commit
that referenced
this pull request
Dec 4, 2016
reverts #107, seems like rule name was removed
adenflorian
pushed a commit
to adenflorian/vscode-tslint
that referenced
this pull request
Oct 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current regexp pattern does not take the rule name into account which results in file names like the following (which of course cannot be opened by VS Code):
(no-shadowed-variable) src/...