Update to JDK 17 #35
Update to JDK 17 #35
Conversation
| // Append -bullseye or -buster to pin to an OS version. | ||
| // Use the -bullseye variants on local arm64/Apple Silicon. | ||
| "VARIANT": "11-bullseye", | ||
| "VARIANT": "17-bullseye", |
There was a problem hiding this comment.
@chrmarti @joshspicer I see in the vscode-dev-containers Java definition, we default to 11-bullseye too: https://github.com/microsoft/vscode-dev-containers/blob/main/containers/java/.devcontainer/devcontainer.json#L9. Do you think we should update both to 17?
There was a problem hiding this comment.
All Azure services have now Java 17 support, using the Microsoft build of OpenJDK. It's the current LTS version, and we should now use it by default, instead of an older release.
I believe we should update both, do you want me to do a PR on the other project?
There was a problem hiding this comment.
Makes sense. Thanks @jdubois! I agree, we should also update vscode-dev-container.
There was a problem hiding this comment.
Thanks for the insights @jdubois! Yes, if you put up a PR on vscode-dev-container, we would definitely appreciate that.
Below is the source code for what we publish to MCR under mcr.microsoft.com/vscode/devcontainers/java, as well as the source for the devcontainer templates we provide in Codespaces and the VS Code Remote-Containers extension.
https://github.com/microsoft/vscode-dev-containers/tree/main/containers/java
https://github.com/microsoft/vscode-dev-containers/tree/main/containers/java-8
@bamurtaugh - how do we sync these vscode-remote-try-* repos? Is it automated or manual?
There was a problem hiding this comment.
Awesome! I’ll do the PR in the next few days
There was a problem hiding this comment.
Great! Feel free to tag me on that repo (where I can merge PRs) when you're all set (or if there's anything I can help out with/clarify)
There was a problem hiding this comment.
how do we sync these vscode-remote-try-* repos? Is it automated or manual?
As in how do we sync them into the tooling (i.e. Remote-Containers), or how do we keep them in sync with vscode-dev-containers?
If the latter, it's manual AFAIK. For the former, I think it's automatic, but @chrmarti could confirm.
There was a problem hiding this comment.
The vscode-remote-try-* repositories are only referenced by URL from Remote-Containers, so no update needed on that side.
brunoborges
left a comment
brunoborges
left a comment
There was a problem hiding this comment.
You should also update Maven here.
|
@brunoborges that’s PR #36 (because I do clean separated PRs, but you are right, there is an issue here we know thanks to @roryp 😀) |
|
Thanks all for the discussion here. Sounds like this is good to merge, so I'll go ahead and merge it. If there are any other thoughts, please just let me know. |
5 participants
JDK 17 is the new long-term support release, and is available on Azure now (so this what everyone should use by default)