modifications to angular flow#177
Merged
auchenberg merged 2 commits intomicrosoft:masterfrom Feb 4, 2019
Merged
Conversation
microsoft/vscode#64447 The tutorial as it stands creates a bit of ambiguity by defining a problem matcher for a background task, but not running the task in the background. Also, ng serve task was not defined as a preLaunch task. The guide instructed a user to follow a clunky flow. Also, "identifiers" are deprecated and serve only to confuse new users. Therefore updated.
fix regex and ordering
|
|
Contributor
Author
|
The guy that made volkswagen-lib is reviewing my PR, sick. |
Contributor
Author
|
Fixes #159 |
Contributor
|
Thanks for the great PR. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/vscode#64447
The tutorial as it stands creates a bit of ambiguity by defining a problem matcher for a background task, but not running the task in the background. Also, ng serve task was not defined as a preLaunch task. The guide instructed a user to follow a clunky flow.
Also, "identifiers" are deprecated and serve only to confuse new users. Therefore updated.