Pull request for Jest issue - SecurityError: localStorage is not available for opaque origins #119#120
Merged
auchenberg merged 2 commits intomicrosoft:masterfrom Jul 30, 2018
Conversation
Pull request for Issue reported below: Jest error - SecurityError: localStorage is not available for opaque origins microsoft#119
Pull request for Jest error - SecurityError: localStorage is not available for opaque origins microsoft#119 Please excuse any inconvenience I may have caused as I this is only my first commit on github public repository.
|
|
Contributor
|
Thanks @NileshParkhe83 this looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for Jest error - SecurityError: localStorage is not available for opaque origins #119
Jsdom just recently upgraded to version 11.12, which includes support for window.localStorage and other features. See https://github.com/jsdom/jsdom/blob/master/Changelog.md.
Jest does not raise above error when Node is specified as the test environment.
Pull request raised to add above change to documentation if appropriate.
Please excuse any inconvenience I may cause. This is my first pull request on a public github repository.
Thanks.