jest debugging : fixed program path so it also works with jest-cli#106
Merged
auchenberg merged 1 commit intomicrosoft:masterfrom Jun 18, 2018
Merged
jest debugging : fixed program path so it also works with jest-cli#106auchenberg merged 1 commit intomicrosoft:masterfrom
auchenberg merged 1 commit intomicrosoft:masterfrom
Conversation
If a VS code user uses react-boilerplate, he will install jest-cli as a dependency and there won't be any jest folder. So replaced the `program` path so it uses `node_modules/.bin/jest` which will work in both cases
Contributor
|
LGTM! Thanks @fallanic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today (06/18), if a VS code user uses react-boilerplate, he will install jest-cli as a dev dependency and there won't be any
node_modules/jestfolder, and these two debug configurations won't work.So replaced the
programpath, so it usesnode_modules/.bin/jestwhich will work when having eitherjestorjest-clias a dev dependency.It took me a little while to understand why these configs didn't work on my end even if they looked good, I hope this can save other VS Code users some time 🙂