Skip to content

Fix boundled/server wrong lsp ref and language server missing param #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karthiknadig merged 2 commits into from
Jan 20, 2023
Merged

Fix boundled/server wrong lsp ref and language server missing param #92

karthiknadig merged 2 commits into from
Jan 20, 2023

Conversation

@ischaojie
Copy link
Contributor

@ischaojie ischaojie commented Jan 20, 2023 •
edited
Loading

When using this template for developing a plugin, I found some wrong code at server.py:

  1. Cannot import lsp from pygls.
  2. LanguageServer missing some params.

karthiknadig
karthiknadig reviewed Jan 20, 2023
View reviewed changes
@karthiknadig
Copy link
Member

karthiknadig commented Jan 20, 2023

@ischaojie Thanks for the PR. This is a good catch. I have left a comment can you address that as well?

@karthiknadig karthiknadig self-assigned this Jan 20, 2023
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Jan 20, 2023
@karthiknadig karthiknadig enabled auto-merge (squash) January 20, 2023 07:06
@karthiknadig karthiknadig merged commit b3e917b into microsoft:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

Assignees

@karthiknadig karthiknadig

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ischaojie @karthiknadig @eleanorjboyd