Skip to content

Fix atexit exception #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karthiknadig merged 1 commit into from
Dec 19, 2022
Merged

Fix atexit exception #84

karthiknadig merged 1 commit into from
Dec 19, 2022

Conversation

@eddyg
Copy link
Contributor

@eddyg eddyg commented Dec 7, 2022

The current implementation results in the "Output" tab for the extension showing:

Exception ignored in atexit callback: <function ProcessManager.stop_all_processes at 0x10298a320>
TypeError: ProcessManager.stop_all_processes() missing 1 required positional argument: 'self'

(This fixes #83)

@karthiknadig karthiknadig merged commit cf0571d into microsoft:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

atexit.register decorator causes exception

2 participants

@eddyg @karthiknadig