Skip to content

Conversation

@pan93412
Copy link

@pan93412 pan93412 commented Jan 11, 2020

For #9548.
Closed #9548.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #9547 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9547      +/-   ##
=========================================
- Coverage   60.83%   60.8%   -0.03%     
=========================================
  Files         530     540      +10     
  Lines       28645   29440     +795     
  Branches     4344    4500     +156     
=========================================
+ Hits        17425   17900     +475     
- Misses      10261   10530     +269     
- Partials      959    1010      +51
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterVariables.ts 48.64% <0%> (-13.33%) ⬇️
...science/jupyter/liveshare/guestJupyterExecution.ts 12.5% <0%> (-5.87%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 18.04% <0%> (-1.47%) ⬇️
...ce/interactive-window/interactiveWindowProvider.ts 13.68% <0%> (-1.44%) ⬇️
...ascience/interactive-ipynb/nativeEditorProvider.ts 52.94% <0%> (-0.81%) ⬇️
...lient/datascience/jupyter/kernels/kernelService.ts 54.16% <0%> (-0.76%) ⬇️
src/client/datascience/jupyter/jupyterSession.ts 67.64% <0%> (-0.67%) ⬇️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 10.18% <0%> (-0.2%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 4.59% <0%> (-0.2%) ⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts 56.26% <0%> (-0.19%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96872e4...3e214f1. Read the comment docs.

@karthiknadig karthiknadig self-requested a review January 13, 2020 20:59
Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pan93412 Thanks for the translation. I have a minor suggestion to add your github details to the markdown (so you get credit for this).

thanks to karthiknadig!

Co-Authored-By: Karthik Nadig <[email protected]>
@pan93412 pan93412 requested a review from karthiknadig January 15, 2020 02:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 3 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@karthiknadig karthiknadig merged commit a4ccef2 into microsoft:master Jan 16, 2020
@pan93412 pan93412 deleted the patch-1 branch January 19, 2020 11:17
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

l10n: zh_TW: update translation

3 participants