Skip to content

Throw error when unable to compute file hash #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 1 commit into from
Aug 13, 2019
Merged

Throw error when unable to compute file hash #6954

DonJayamanne merged 1 commit into from
Aug 13, 2019

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Aug 13, 2019

For #5926

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Aug 13, 2019
ericsnowcurrently
ericsnowcurrently approved these changes Aug 13, 2019
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne DonJayamanne merged commit 10ab7e7 into microsoft:master Aug 13, 2019
@DonJayamanne DonJayamanne deleted the fsHash branch August 13, 2019 19:15
@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DonJayamanne @ericsnowcurrently