Skip to content

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Aug 12, 2019

For #6938

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@ericsnowcurrently ericsnowcurrently self-requested a review August 12, 2019 17:23
@DonJayamanne DonJayamanne merged commit 9c61d0e into microsoft:master Aug 12, 2019
@DonJayamanne DonJayamanne deleted the codecov branch August 12, 2019 17:46
@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants