Skip to content

Send "relpath" back for all test files/folders. #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsnowcurrently merged 21 commits into from
Aug 8, 2019
Merged

Send "relpath" back for all test files/folders. #6877

ericsnowcurrently merged 21 commits into from
Aug 8, 2019
+2,074 −1,025

Conversation

@ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Aug 6, 2019 •
edited
Loading

(for #6758)

The key changes:

  • leave node IDs alone (do not normcase)
  • preserve the "relpath" of each file/folder
  • send that relpath back in the results
  • generate "TestFile.fullPath" (in discovery parser) using relpath instead of ID

There is also a bunch of cleanup (in cases where the code was cluttered enough that I was worried about missing something). (sorry) If that is a problem then let me know and we can walk through the PR.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [ ] Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Aug 6, 2019
@karrtikr karrtikr self-assigned this Aug 6, 2019
@ericsnowcurrently
Copy link
Author

ericsnowcurrently commented Aug 6, 2019

FYI, I know what the problem is in Windows CI and will fix it soon.

karrtikr
karrtikr approved these changes Aug 6, 2019
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the key changes go, this looks good to me.

@ericsnowcurrently ericsnowcurrently merged commit 931757b into microsoft:master Aug 8, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-6758-parent-locations branch August 8, 2019 22:05
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 12, 2019
Merged
4 tasks
ericsnowcurrently pushed a commit that referenced this pull request Aug 12, 2019
Fix failing functional extension tests in CI related to pytest discov…
707b5e7 
…ery. (#6944)

(for #6940)

This is essentially a follow-up to #6877 (for #6758).
This was referenced Aug 13, 2019
Closed
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently @karrtikr