Skip to content

Changes to how shell in terminal is identified #5886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 3 commits into from
Jun 4, 2019
Merged

Changes to how shell in terminal is identified #5886

DonJayamanne merged 3 commits into from
Jun 4, 2019

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jun 3, 2019

For #5743

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

karrtikr
karrtikr suggested changes Jun 4, 2019
View reviewed changes
@DonJayamanne DonJayamanne merged commit a328783 into microsoft:master Jun 4, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 4, 2019

@karrtikr Merged this PR, as we need this ASAP. and the issue was only with missing test.
I've added the test, I am assuming you are ok with me merging the PR once the tests have been added.

@Tyriar
Copy link
Member

Tyriar commented Jun 4, 2019

@DonJayamanne thanks for fixing so quickly 😃

@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 4, 2019

@Tyriar
Team effort.

@DonJayamanne DonJayamanne deleted the issue5743 branch June 6, 2019 22:23
@Eskibear Eskibear mentioned this pull request Jun 10, 2019
Merged
@Tyriar Tyriar mentioned this pull request Jun 17, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@karrtikr karrtikr karrtikr requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonJayamanne @Tyriar @karrtikr