Skip to content

gh-978: Add python.pipenvPath config setting. #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsnowcurrently merged 11 commits into from
Jan 11, 2019
Merged

gh-978: Add python.pipenvPath config setting. #3957

ericsnowcurrently merged 11 commits into from
Jan 11, 2019

Conversation

@ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Jan 10, 2019

(fixes #978)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Jan 10, 2019 •
edited
Loading

Codecov Report

Merging #3957 into master will decrease coverage by 1%.
The diff coverage is 93%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3957    +/-   ##
=======================================
- Coverage      78%     78%   -<1%     
=======================================
  Files         406     406            
  Lines       18852   18861     +9     
  Branches     3025    3026     +1     
=======================================
+ Hits        14577   14578     +1     
- Misses       4273    4281     +8     
  Partials        2       2
Flag Coverage Δ
#Linux 68% <65%> (ø) ⬇️
#Windows 68% <65%> (ø) ⬇️
#macOS 68% <65%> (ø) ⬇️
Impacted Files Coverage Δ
src/client/interpreter/contracts.ts 100% <ø> (ø) ⬆️
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/common/configSettings.ts 94% <100%> (+1%) ⬆️
...entActivationProviders/pipEnvActivationProvider.ts 79% <100%> (+6%) ⬆️
...ent/interpreter/locators/services/pipEnvService.ts 87% <80%> (ø) ⬇️
...tors/services/workspaceVirtualEnvWatcherService.ts 85% <0%> (-5%) ⬇️
src/client/common/process/pythonProcess.ts 89% <0%> (-3%) ⬇️
...rpreter/locators/services/baseVirtualEnvService.ts 86% <0%> (-2%) ⬇️
src/client/interpreter/helpers.ts 78% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1964fd...565483b. Read the comment docs.

DonJayamanne
DonJayamanne approved these changes Jan 10, 2019
View reviewed changes
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be merging #3930 shortly, you'll need to modify src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts file as well.

@ericsnowcurrently ericsnowcurrently force-pushed the fix-978-add-pipenvPath-setting branch from 884af91 to 565483b Compare January 11, 2019 00:17
@ericsnowcurrently
Copy link
Author

ericsnowcurrently commented Jan 11, 2019

FYI, I updated the activation provider.

@ericsnowcurrently ericsnowcurrently merged commit 26e75fd into microsoft:master Jan 11, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-978-add-pipenvPath-setting branch January 11, 2019 00:52
@DonJayamanne DonJayamanne mentioned this pull request Jan 11, 2019
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jan 14, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

be able to specify the path to pipenv

2 participants

@ericsnowcurrently @DonJayamanne