Skip to content

Conversation

@DonJayamanne
Copy link

Fixes #2587 (fixes bug introduced by #2552)

  • The launch.json can contain the value $config:python.pythonPath} as the value for the python path. We need to account for this value when validating the python path before debugging.
  • Also moved validation code into a separate method of the diagnostics class.
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • Has unit tests & system/integration tests
  • [n/a] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne changed the title Handle config:python.pythonPath when validating path when debugging Handle config:python.pythonPath when validating path before debugging Sep 14, 2018
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DonJayamanne DonJayamanne merged commit dff2699 into microsoft:master Sep 14, 2018
@DonJayamanne DonJayamanne deleted the issue2587ResolveConfig branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Presence of "pythonPath": "${config:python.pythonPath}" in launch.json results in display of error message

2 participants