Skip to content

Conversation

@DonJayamanne
Copy link

Fixes #1526

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has unit tests & system/integration tests
  • [n/a] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne requested review from d3r3kk and removed request for d3r3kk September 13, 2018 20:30
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d3r3kk
Copy link

d3r3kk commented Sep 13, 2018

Again - feel free to disable Multiple linters tests with this PR and open an issue for me - I'll get to it later on tomorrow, or perhaps Monday.

@DonJayamanne DonJayamanne merged commit bcd7dfd into microsoft:master Sep 13, 2018
@DonJayamanne DonJayamanne deleted the issue1526PyEnvActivate branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Terminal does not activate pyenv environments

2 participants