Consolidate util code to src/util/*. #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested changes
Sep 5, 2018
| const mockVariables: EnvironmentVariables = {}; | ||
| if (envVars) { | ||
| for (const [key, value] of envVars.entries!) { | ||
| if (envVars && envVars.keys) { |
|
|
||
| // tslint:disable-next-line: no-suspicious-comment | ||
| // TODO: Usage of these should be replaced by OSInfo.* or | ||
| // IPlatformService.* (from src/client/common/platform). |
Author
There was a problem hiding this comment.
This is a TODO comment. There is no commented code.
| protected debugSession: DebugSession; | ||
|
|
||
| protected isRunning: boolean; | ||
| protected isRunning?: boolean; |
There was a problem hiding this comment.
No change required:
Or you could just change this to initialize isRunning to false
DonJayamanne
approved these changes
Sep 5, 2018
Member
|
FYI the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has a news entry file (remember to thank yourself!)Any new/changed dependencies inpackage.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)This is a follow-up to #2456. I've pulled many of the "util" modules out of
src/client/commoninto a new sibling package toclient:utils. This helps us separate the extension-specific code from the generic code we use for the extension.Note that this PR includes only the following: