Ensure EventListeners for unittest test results are not registered multiple times
#2383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2383 +/- ##
==========================================
+ Coverage 75.38% 75.39% +<.01%
==========================================
Files 309 309
Lines 14331 14332 +1
Branches 2537 2537
==========================================
+ Hits 10804 10806 +2
+ Misses 3518 3517 -1
Partials 9 9
Continue to review full report at Codecov.
|
d3r3kk
changed the title
unittest test results are not registered multiple timesunittest test results are not registered multiple times
|
I attempted to correct how I'm registering the callbacks to limit the number of times we need to register/unregister, but I've not been successful. If I register each time we run tests, then unregister, it solves the problem. This is the solution I'm proposing with this PR. Ideally though, I'd want to simply register the events once in the constructor (or alternatively, in a single-shot 'register once then skip subsequent registrations' method). And never unregister my event handlers for the duration of the execution of the extension. This seems simpler to me. However, I haven't been able to successfully register once and have it work, I am 100% open to suggestions as I think my ideal solution would be simpler! |
| @@ -1,13 +1,22 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
This isn't a new file, so don't add the copyright header.
| }); | ||
|
|
||
| this.server.on('socket.disconnected', (socket: Socket, isSocketDestroyed: boolean) => { | ||
| this.server.removeAllListeners('error'); |
There was a problem hiding this comment.
Is there a list of all the possible values to make sure this doesn't skew in the future if more options come up?
There was a problem hiding this comment.
Yep, I can improve upon this and just remove all event listeners altogether. I'll do that as it seems more forward-thinking.
Fixes microsoft#2143 - Unregister listeners from socket service after each test run
- Update related code files to correct for linter errors - Add (commented out) unit test method - Create Python test files for test count issues
- NOTE: 2x test works, (3+N)x does not. - Perhaps a timeout issue, but might be worse - Will try a different solution to see if I can get this sorted.
Not a new file.
- allow for not specifying the specific event listener to remove
2 participants
Fixes #2143, unit test counts in the VSCode status bar are not reflecting correct quantities.