Skip to content

[WIP] Use symbol provider from new language server to place code lenses in tests #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne wants to merge 1 commit into from
Closed

[WIP] Use symbol provider from new language server to place code lenses in tests #2197

DonJayamanne wants to merge 1 commit into from

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jul 19, 2018 •
edited
Loading

Fixes #1948

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
  • package-lock.json has been regenerated if dependencies have changed

@DonJayamanne
Copy link
Author

DonJayamanne commented Jul 21, 2018

This relies on #2050

@codecov
Copy link

codecov bot commented Jul 24, 2018 •
edited
Loading

Codecov Report

Merging #2197 into master will decrease coverage by 0.04%.
The diff coverage is 68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2197      +/-   ##
=========================================
- Coverage   79.84%   79.8%   -0.05%     
=========================================
  Files         310     312       +2     
  Lines       14359   14394      +35     
  Branches     2547    2558      +11     
=========================================
+ Hits        11465   11487      +22     
- Misses       2882    2895      +13     
  Partials       12      12
Flag Coverage Δ
#MacOS 73.94% <68%> (-0.02%) ⬇️
#Windows 74.11% <68%> (ø) ⬆️
Impacted Files Coverage Δ
src/client/unittests/codeLenses/main.ts 88.88% <ø> (ø) ⬆️
src/client/unittests/types.ts 100% <ø> (ø) ⬆️
src/client/activation/serviceRegistry.ts 100% <100%> (ø) ⬆️
src/client/unittests/main.ts 46.69% <100%> (ø) ⬆️
src/client/activation/jedi.ts 94% <100%> (+0.12%) ⬆️
src/client/providers/symbolProvider.ts 80% <100%> (-6.54%) ⬇️
src/client/activation/symbolProvider.ts 20% <20%> (ø)
src/client/unittests/codeLenses/testFiles.ts 32.78% <26.31%> (-0.27%) ⬇️
src/client/activation/languageServer.ts 26.2% <37.5%> (+0.11%) ⬆️
src/client/providers/throttledSymbolProvider.ts 97.05% <97.05%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af8f99...cafb5bb. Read the comment docs.

@d3r3kk
Copy link

d3r3kk commented Jul 24, 2018

When you get a moment, rebuild this PR, the mac agents recently were updated to python 3.7.

@DonJayamanne DonJayamanne reopened this Jul 24, 2018
@DonJayamanne DonJayamanne mentioned this pull request Jul 27, 2018
Closed
@brettcannon brettcannon changed the title WIP - Use symbol provider from new language server to place code lenses in tests [WIP] Use symbol provider from new language server to place code lenses in tests Aug 1, 2018
@DonJayamanne DonJayamanne mentioned this pull request Aug 3, 2018
Closed
@brettcannon
Copy link
Member

brettcannon commented Aug 20, 2018

@DonJayamanne is this still a WIP?

@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 28, 2018
Merged
5 tasks
@brettcannon
Copy link
Member

brettcannon commented Aug 29, 2018

@DonJayamanne #2456 is this PR to just add language server support so we can get it for this release.

@DonJayamanne
Copy link
Author

DonJayamanne commented Sep 6, 2018

closing as the work has been completed in another PR by @ericsnowcurrently

@DonJayamanne DonJayamanne deleted the issue1948TestCodeLenses branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code Lenses not appearing in Unit Tests when using the new language server

3 participants

@DonJayamanne @d3r3kk @brettcannon