Skip to content

Change keymapping for run selection/line in Python terminal #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d3r3kk merged 2 commits into from
Jul 9, 2018
Merged

Change keymapping for run selection/line in Python terminal #2077

d3r3kk merged 2 commits into from
Jul 9, 2018

Conversation

@d3r3kk
Copy link

@d3r3kk d3r3kk commented Jun 30, 2018 •
edited
Loading

Fixes #2068

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@d3r3kk d3r3kk requested a review from DonJayamanne June 30, 2018 00:45
@codecov
Copy link

codecov bot commented Jun 30, 2018 •
edited
Loading

Codecov Report

Merging #2077 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
+ Coverage   79.81%   79.96%   +0.14%     
==========================================
  Files         307      307              
  Lines       14086    14083       -3     
  Branches     2499     2499              
==========================================
+ Hits        11243    11261      +18     
+ Misses       2831     2810      -21     
  Partials       12       12
Flag Coverage Δ
#MacOS 74.08% <ø> (+0.07%) ⬆️
#Windows 74.22% <ø> (+0.13%) ⬆️
Impacted Files Coverage Δ
src/client/providers/providerUtilities.ts 94.44% <0%> (-5.56%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 68.09% <0%> (-0.33%) ⬇️
src/client/debugger/Main.ts 67.16% <0%> (+0.24%) ⬆️
src/client/providers/signatureProvider.ts 90% <0%> (+0.71%) ⬆️
src/client/providers/completionSource.ts 98.14% <0%> (+1.53%) ⬆️
src/client/providers/symbolProvider.ts 86.53% <0%> (+1.92%) ⬆️
src/client/providers/jediProxy.ts 80% <0%> (+3.82%) ⬆️
src/client/languageServices/jediProxyFactory.ts 81.81% <0%> (+4.54%) ⬆️
src/client/common/logger.ts 63.15% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda34d4...2fa54ce. Read the comment docs.

@DonJayamanne
Copy link

DonJayamanne commented Jun 30, 2018

You probably didn't see my message #2068 (comment)

@d3r3kk
Copy link
Author

d3r3kk commented Jul 2, 2018

@DonJayamanne I did. Have I missed something?

@d3r3kk
Go back to shift+enter
2fa54ce 
- use when clause to not conflict with find/replace widgets
@d3r3kk d3r3kk merged commit 891fb35 into microsoft:master Jul 9, 2018
@d3r3kk d3r3kk deleted the run-line branch July 9, 2018 17:23
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't trigger keyboard shortcuts while searching

2 participants

@d3r3kk @DonJayamanne