Skip to content

Comments

Do not use deprecated poetry --dev option for installing packages#19980

Merged
karrtikr merged 2 commits intomicrosoft:mainfrom
SaidBySolo:poetry-migation
Oct 11, 2022
Merged

Do not use deprecated poetry --dev option for installing packages#19980
karrtikr merged 2 commits intomicrosoft:mainfrom
SaidBySolo:poetry-migation

Conversation

@SaidBySolo
Copy link

@SaidBySolo SaidBySolo commented Oct 10, 2022 •
edited by karrtikr
Loading

@karthiknadig karthiknadig requested a review from karrtikr October 10, 2022 16:30
karrtikr
karrtikr suggested changes Oct 11, 2022
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaidBySolo Thanks for the PR. Can you link to when was --group flag released? We should make sure this has been out long enough (usually one year) so it can be used with older versions of poetry, before we can accept this PR as is.

@karrtikr karrtikr changed the title fix(poetry): --dev option is deprecated Do not use deprecated --dev option poetry for installing packages Oct 11, 2022
@karrtikr karrtikr added the feature-request Request for new features or functionality label Oct 11, 2022
@SaidBySolo
Copy link
Author

SaidBySolo commented Oct 11, 2022 •
edited
Loading

@karrtikr

https://github.com/python-poetry/poetry/releases/tag/1.2.0a2

It appears to have been released on August 1, 2021.

I think enough time has passed :D

@SaidBySolo SaidBySolo requested a review from karrtikr October 11, 2022 03:20
@karrtikr karrtikr changed the title Do not use deprecated --dev option poetry for installing packages Do not use deprecated poetry --dev option for installing packages Oct 11, 2022
@karrtikr karrtikr mentioned this pull request Oct 11, 2022
Closed
karrtikr
karrtikr approved these changes Oct 11, 2022
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then :)

@karrtikr karrtikr merged commit af9793f into microsoft:main Oct 11, 2022
@levrik
Copy link

levrik commented Nov 4, 2022 •
edited
Loading

@SaidBySolo This was an alpha release of Poetry 1.2.0. The stable release actually happened just on August 31, 2022. Not all of our projects have migrated to Poetry 1.2.0 yet so this change is very likely to break things for some users.

https://github.com/python-poetry/poetry/releases/tag/1.2.0

@SaidBySolo
Copy link
Author

SaidBySolo commented Nov 4, 2022 •
edited
Loading

@levrik

I think it's good to migrate as soon as possible.

The poetry team has officially dropped support for 1.1.

However, if the MS prioritizes backwards compatibility, i respect that.

2CE9A125-CAF6-46DB-96DD-1E64B6C19D70

wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@SaidBySolo @wesm
Do not use deprecated poetry --dev option for installing packages (m…
a67662c 
…icrosoft/vscode-python#19980)

Closes microsoft/vscode-python#19983

https://python-poetry.org/docs/managing-dependencies/#dependency-groups

python-poetry/poetry#6475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

feature-request Request for new features or functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use --group dev instead of --dev flag for poetry package installation

3 participants

@SaidBySolo @levrik @karrtikr