Skip to content

Conversation

@lramos15
Copy link
Member

Please review but do not merge. I must get some tokens added

@lramos15 lramos15 requested a review from brettcannon August 16, 2022 19:26
@brettcannon brettcannon added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Aug 16, 2022
brettcannon
brettcannon previously approved these changes Aug 16, 2022
@brettcannon
Copy link
Member

Only issue seems to be the file wasn't run through Prettier.

@lramos15
Copy link
Member Author

Sorry! It was stolen from https://raw.githubusercontent.com/microsoft/vscode-pull-request-github/main/.github/workflows/pr-chat.yml which is the base .yml I've used for every repo. Just don't look at it :p

@lramos15
Copy link
Member Author

Update, prettier doesn't work in github.dev and I didn't even realize it (it needs an installed binary :p). I have gone ahead and fixed the linting issue

@karthiknadig karthiknadig merged commit f0c55b7 into main Aug 17, 2022
@karthiknadig karthiknadig deleted the lramos15/prChat branch August 17, 2022 18:32
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants