Goto definition + symbols via language server #1934
Conversation
DonJayamanne
left a comment
DonJayamanne
left a comment
There was a problem hiding this comment.
I'll test this tomorrow with the integration with the code lenses for Unit tests.
Will approve once that functionality works as expected.
src/client/activation/analysis.ts
Outdated
| let pythonPath = (await envProvider.getEnvironmentVariables()).PYTHONPATH; | ||
| this.interpreterHash = interpreterData ? interpreterData.hash : ''; | ||
|
|
||
| searchPaths = searchPaths.replace(/\\\\/g, '\\'); |
There was a problem hiding this comment.
Why are we doing this? Please could you document the use case.
Is this for Windows Only? You might want to consider using path.normalize(searchPaths)
That function removes unnecessary (duplicate) path separators.
There was a problem hiding this comment.
OK, will use normalize. I think it is somewhere is node when converting settings in JSON. Generally it doesn't matter for file system operations as both .NET and node ignore duplicate backslashes. However, it matters in the language server that is tracking documents by URI and different number of backslashes produces different URI strings.
There was a problem hiding this comment.
There is, however, difficultly with search paths since it is a single string which would have to be split and re-joined.
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
=========================================
+ Coverage 74.35% 74.75% +0.4%
=========================================
Files 283 285 +2
Lines 13287 13456 +169
Branches 2387 2426 +39
=========================================
+ Hits 9879 10059 +180
+ Misses 3273 3266 -7
+ Partials 135 131 -4
Continue to review full report at Codecov.
|
2 participants
Fixes #1013
Fixes #1776
This pull request:
PTVS PR microsoft/PTVS#4354