Skip to content

Fix HOME folder substitution when is not in the beginning of path #19326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karrtikr merged 1 commit into from
Aug 2, 2022
Merged

Fix HOME folder substitution when is not in the beginning of path #19326

karrtikr merged 1 commit into from
Aug 2, 2022

Conversation

@cpinamtz
Copy link

@cpinamtz cpinamtz commented Jun 18, 2022 •
edited by karrtikr
Loading

Closes #18532

@ghost
Copy link

ghost commented Jun 18, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@cpinamtz
Copy link
Author

cpinamtz commented Jun 20, 2022 •
edited
Loading

Do I need to re-create the PR but with a branch named just bug? First time contributing here

@karrtikr karrtikr added the bug Issue identified by VS Code Team member as probable bug label Jun 20, 2022
@karrtikr
Copy link

karrtikr commented Jun 20, 2022

Thanks for the PR, I plan to have a look soon. We just needed to add the label bug.

@karrtikr karrtikr self-requested a review June 21, 2022 18:03
karrtikr
karrtikr approved these changes Aug 2, 2022
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Appreciate the comprehensive work.

@karrtikr karrtikr merged commit 3c84012 into microsoft:main Aug 2, 2022
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@cpinamtz @wesm
Fix HOME folder substitution when is not in the beginning of path (mi…
2520872 
…crosoft/vscode-python#19326)
@cpinamtz cpinamtz deleted the bugfix/18532 branch June 1, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replacing home dir with ~ sometimes leads to invalid path

2 participants

@cpinamtz @karrtikr