Fix new unittest discovery issue #19324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
requested changes
Jun 17, 2022
karthiknadig
approved these changes
Jun 22, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Add explicit type to errors list * First pass at test execution (Python-side) * How to swap to the new test adapter * fix new discovery multiclass tests detection * fix new discovery multiclass tests detection * fix duplicate ids for testing treeNodes * remove debugpy import * fixing test_simple_discovery * fix test_error_discovery, simple_tree * fix test_no_existing_child_node and test_get_existing_child_node * fix no_existing_child * fix lint error * fix no_existing str bad operation Co-authored-by: Kim-Adeline Miguel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the new unittest discovery algorithm, where multiple classes and their unittest test cases were not detected (not shown in the UI).
Issue: TestNodes for classes (after the first class in a particular test file) were not getting recognized as different test node because there was not a unique ID for them. Path was getting passed into parameter in workspaceTestAdapter.ts, instead of uniqueID.
Solution: Added uniqueID attribute for both python and typescript side to generate appropriate id(in python side) for not only specific test case, but also for classes (which should also have been considered as a testnode).