Skip to content

Fixed problem where match string contain special characters #18878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karrtikr merged 9 commits into from
Apr 11, 2022
Merged

Fixed problem where match string contain special characters #18878

karrtikr merged 9 commits into from
Apr 11, 2022

Conversation

@sunyinqi0508
Copy link

@sunyinqi0508 sunyinqi0508 commented Apr 7, 2022 •
edited by karrtikr
Loading

Closes #18829

@sunyinqi0508 sunyinqi0508 mentioned this pull request Apr 7, 2022
Closed
2 tasks
@karthiknadig karthiknadig requested a review from karrtikr April 7, 2022 17:00
karrtikr
karrtikr reviewed Apr 7, 2022
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please add a news entry thanking yourself (see news/README.md for details).

karrtikr
karrtikr reviewed Apr 7, 2022
View reviewed changes
@ghost
Copy link

ghost commented Apr 8, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

karrtikr
karrtikr reviewed Apr 9, 2022
View reviewed changes
@karrtikr karrtikr added the skip tests Updates to tests unnecessary label Apr 9, 2022
@karrtikr karrtikr self-assigned this Apr 9, 2022
karrtikr
karrtikr reviewed Apr 11, 2022
View reviewed changes
karrtikr
karrtikr approved these changes Apr 11, 2022
View reviewed changes
Copy link

@karrtikr karrtikr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for investigating the cause, this could potentially fix a lot of ongoing issues like #18567 #18478 #18437!

@karrtikr karrtikr merged commit 5932e99 into microsoft:main Apr 11, 2022
@karrtikr karrtikr mentioned this pull request Apr 11, 2022
Closed
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@sunyinqi0508 @wesm
Fixed problem where match string contain special characters (microsof…
6316cf9 
…t/vscode-python#18878)

* Fixed problem where match string contain special characters

* Fixes issue where () and | are escaped for windows

* Fixed a problem when some characters are not escaped.
Added Credits.

* Update src/client/common/process/logger.ts

Simplify code.

Co-authored-by: Kartik Raj <[email protected]>

* Only replace '\\' with '(\\|/)' on Windows to save a scan on other OSs.

* Update src/client/common/process/logger.ts

Co-authored-by: Kartik Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthiknadig karthiknadig

@karrtikr karrtikr

Labels

skip tests Updates to tests unnecessary

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid regular expression logging error occurs when file paths contain special characters

3 participants

@sunyinqi0508 @karrtikr @karthiknadig