Skip to content

Conversation

@sisoe24
Copy link

@sisoe24 sisoe24 commented Feb 24, 2022

Closes #18553

  • Properly dismiss the error popup dialog for linter errors.

@ghost
Copy link

ghost commented Feb 24, 2022

CLA assistant check
All CLA requirements met.

@sisoe24
Copy link
Author

sisoe24 commented Mar 7, 2022

Is the error on me? I actually haven't done any tests

@Harry-Hopkinson
Copy link

Tests are not really required for this PR

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@karrtikr karrtikr added no-changelog No news entry required skip tests Updates to tests unnecessary and removed no-changelog No news entry required labels Mar 7, 2022
@karrtikr karrtikr merged commit 10559b8 into microsoft:main Mar 7, 2022
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…on#18583)

* dismiss properly the error dialog

* Add a news entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button "Clear Notification" for showErrorDialog shows the error anyway

3 participants